Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/rails-dom-testing
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: rails/rails-dom-testing
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1-0-stable
Choose a head ref
  • 12 commits
  • 6 files changed
  • 5 contributors

Commits on Dec 27, 2016

  1. Allow Nokogiri 1.7

    @matthewd
    matthewd committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    958b07c View commit details
    Browse the repository at this point in the history

  2. Release 1.0.8

    @matthewd
    matthewd committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    86c7fb1 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. This tries to bundle activesupport 5.0.0.rc2 where we actually need 4… 

    ….2.x
    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    d813d89 View commit details
    Browse the repository at this point in the history

  2. It's because bundler is too old that bundler tries to bundle AS 5.0.0… 

    ….rc2
    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    8594b29 View commit details
    Browse the repository at this point in the history

  3. nokogiri 1.7 requires ruby version >= 2.1.0

    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    81d601d View commit details
    Browse the repository at this point in the history

  4. CI against ruby 2.3

    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    52d250f View commit details
    Browse the repository at this point in the history

  5. Current rails 4.2 doesn't support ruby 2.4 and 2.5

    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    6287c9a View commit details
    Browse the repository at this point in the history

  6. "2.3" seems too fuzzy 

    "Requested binary installation but no rubies are available to download"
    @amatsuda
    amatsuda committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    12c6a4d View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Fix jruby on travis 

    Rails is running against jruby-9.1.15.0 and travis is failing because it
can't seem to install the version it's looking for:

Ref: https://travis-ci.org/rails/rails-dom-testing/jobs/317542357

Since Rails is set to a specific version, this sets rails-dom-testing to
the same version.
    @eileencodes
    eileencodes committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    fbc5a7c View commit details
    Browse the repository at this point in the history

  2. Dup selector string when extracting in case it's frozen 

    Looking forward to Ruby 3 where strings will be immutable by default and Ruby 2 with `# frozen_string_literal: true`, this prevents raising modification of frozen string errors
    @Tonkpils
    Tonkpils committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    388f583 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #70 from Tonkpils/frozen-selector-string-fix 

    Dup selector string when extracting in case it's frozen
    @eileencodes
    eileencodes authored Dec 18, 2017
    Configuration menu
    Copy the full SHA
    4a60c45 View commit details
    Browse the repository at this point in the history

  4. Bump gem version to prep for release

    @eileencodes
    eileencodes committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6ce2cdf View commit details
    Browse the repository at this point in the history
Loading