Skip to content

Commit 27812fc

Browse files
committed
manually install peer dependencies
1 parent 7eed382 commit 27812fc

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

setup.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ def run(self):
119119
npm = shutil.which("npm") # this is required on windows
120120
if npm is None:
121121
raise RuntimeError("NPM is not installed.")
122+
123+
# Required on when using NPM >3
124+
log.info(f"> Installing rollup, react, and react-dom")
125+
subprocess.run(f"{npm} install rollup".split(), cwd=js_dir, check=True)
126+
subprocess.run(f"{npm} install react".split(), cwd=js_dir, check=True)
127+
subprocess.run(f"{npm} install react-dom".split(), cwd=js_dir, check=True)
128+
122129
for args in (f"{npm} install", f"{npm} run build"):
123130
args_list = args.split()
124131
log.info(f"> {list2cmdline(args_list)}")

src/js/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,14 @@
1212
},
1313
"devDependencies": {
1414
"prettier": "^2.2.1",
15-
"rollup": "^2.35.1",
15+
"rollup": "^2.56.3",
1616
"rollup-plugin-commonjs": "^10.1.0",
1717
"rollup-plugin-node-resolve": "^5.2.0",
1818
"rollup-plugin-replace": "^2.2.0"
1919
},
2020
"dependencies": {
21-
"idom-client-react": "^0.33.0"
21+
"idom-client-react": "^0.33.0",
22+
"react": "^17.0.2",
23+
"react-dom": "^17.0.2"
2224
}
2325
}

0 commit comments

Comments
 (0)