-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter-spacing for japanese #136
Comments
Letter spacing has also been implemented in the Preferences API for Readium Mobile. |
Thanks for the quick feedback, I guess this pretty much answers this question then. 🙏 |
just to be clear, Thorium has always offered letter-spacing but the issue was that ReadiumCSS was explicitly excluding Japanese, so we forced this. |
also, word-spacing for Japanese with wbr elements required CSS and JavaScript tricks to get working. it is a non-standard technique but it works for Thorium JA users. |
We have letter-spacing in the mobile toolkits but it's only marked as "effective" with the default stylesheet – so no CJK or RTL. We followed the instructions from Readium CSS's doc. Let me know if it needs to be updated. |
@mickael-menu not at the moment but there is a use-case for JA users, as demonstrated in Thorium. At the time we researched a11y, resources were lacking for CJK and RTL. It’s probably worth researching this topic again and see if we can enable the setting for more languages. My to-do list then:
|
If you need, I think you could reach out to these users for more insights with CJK:
In particular, it looks like the paginated mode doesn't work as they expected. |
Some interesting issues from WCAG – looks like we’re not the only ones struggling on this topic:
|
Proposed resolution: I guess it will make more sense enabling it for all CJK, and letting implementers enable/disable the setting as they see fit – and make it clear in documentation. |
Thorium ports: - it resolves Letter-spacing for japanese #136 - it resolves User setting to disable/hide ruby #140 - it fixes Width and height safeguards hide audio controls + video #94 - it fixes forcing "start" text alignment (left or right depending on document language) does not work with "inherit" #128
I'm submitting a topic for discussion.
Short description of the issue/suggestion:
letter-spacing
has been enabled as a user setting for Japanese in Thorium and I’m wondering if we should enable it globally in ReadiumCSS.At the time we first checked it was unclear whether it would help A11y-wise for CJK but feedback has been collected since and maybe we could improve on this front.
The text was updated successfully, but these errors were encountered: