Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination is broken on Safari in Version2 #154

Closed
fondoger opened this issue Nov 4, 2024 · 2 comments
Closed

Pagination is broken on Safari in Version2 #154

fondoger opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
2024 Update New discussions, issues and requests triggered by the 2024 update Bug Indicates the issue is a bug

Comments

@fondoger
Copy link

fondoger commented Nov 4, 2024

I'm submitting a bug report.

Short description of the issue

With the latest develop branch, the pagination is no longer working on Safari devices.

With the exactly same web page, the pagination is only not working for iOS devices:

  • Safari iOS (os ver: 18.1) ❌ (Vertical scrolling, non-paginated)
  • Safari Desktop (os ver: 15.1) ❌ (Vertical scrolling, non-paginated)
  • Chrome Desktop ✅ (Horizontal scrolling, paginated)
  • Firefox Desktop ✅ (Horizontal scrolling, paginated)

By manually setting column-width: 45rem; on root node, the pagination on Safari became normal.

@JayPanoz
Copy link
Collaborator

JayPanoz commented Nov 5, 2024

Thanks for reporting that, this is indeed critical.

It looks like this would be the culprit:

/* The column algorithm will prioritize column-count */
--RS__colWidth: auto;

From this commit. I can remember doing that while working on the initial implementation of auto-layout in Readium Playground so something went obviously wrong at that moment cos’ it should have been caught pretty easily.

Will revert this commit and update ReadiumCSS.

@JayPanoz JayPanoz added Bug Indicates the issue is a bug 2024 Update New discussions, issues and requests triggered by the 2024 update labels Nov 5, 2024
@JayPanoz JayPanoz self-assigned this Nov 5, 2024
@JayPanoz
Copy link
Collaborator

JayPanoz commented Nov 5, 2024

@fondoger sorry for this mishap. This should be fixed in v.2.0.0-alpha.3 but do not hesitate to let me know if that's not the case. Thanks again for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024 Update New discussions, issues and requests triggered by the 2024 update Bug Indicates the issue is a bug
Projects
None yet
Development

No branches or pull requests

2 participants