Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class search issues #318

Open
2 tasks
maximz opened this issue Sep 18, 2016 · 0 comments
Open
2 tasks

Fix class search issues #318

maximz opened this issue Sep 18, 2016 · 0 comments
Labels

Comments

@maximz
Copy link
Member

maximz commented Sep 18, 2016

  • “Affordable care ac” works but “affordable care act” doesn’t, because 3-letter words are treated as department names. (Reproduced 9/18/16 for Spring 2015-16.)
  • Problem with "and": "Modern genetics an" works, "Modern genetics and" fails. (Reproduced 9/18/16 for Fall 2016-17).

Perhaps refactor search to work faster, per @bnprks's suggestion: compile one string for each class and just search through this one list of strings, not all object properties. That’s why search is so fast on http://bparks.mycpanel.princeton.edu/search/

@bnprks, want to take this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant