Skip to content

Error in Documentation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Magnitus- opened this issue Jan 20, 2015 · 11 comments
Closed

Error in Documentation #2

Magnitus- opened this issue Jan 20, 2015 · 11 comments

Comments

@Magnitus-
Copy link

In the usage section, you have the following:

var regex = require('regex-utc-date');

Shouldn't it be?:

var regex = require('regex-email ');

@kevva
Copy link
Member

kevva commented Jan 20, 2015

Where?

@Magnitus-
Copy link
Author

There:

https://www.npmjs.com/package/regex-email

EDIT:

Actually, nvm. Just noticed the publisher of the npm package seems to be a different guy and the documentation in the Github repo is correct.

@kevva
Copy link
Member

kevva commented Jan 20, 2015

It's because the package hasn't been published since the README was updated.

@Magnitus-
Copy link
Author

Ok, I'll send an email to the maintainer of the npm repo.

Thanks for a ridiculously quick feedback.

@kevva
Copy link
Member

kevva commented Jan 20, 2015

Just ping him here. @yoshuawuyts, could you do a patch relase?

@Magnitus-
Copy link
Author

Just ping him here, @tunnckoCore

K, I'll contact him there.

EDIT: Actually, sent him an email at his posted email address.

could you do a patch relase?

Do you mean a new npm repo with the right doc? Sounds wasteful if the original publisher of the npm repo can simply patch his release.

@kevva
Copy link
Member

kevva commented Jan 20, 2015

@Magnitus-, that's what I meant :).

@Magnitus-
Copy link
Author

Ok, I'll give him a reasonable amount of time to update and if that hasn't happened by then, then I'll patch.

@kevva
Copy link
Member

kevva commented Jan 20, 2015

@Magnitus-, you don't need to. Just wait.

@kevva kevva closed this as completed Jan 20, 2015
@yoshuawuyts
Copy link
Contributor

Released as 1.0.2. Didn't receive an email by the way 😢

@Magnitus-
Copy link
Author

Sorry, the mailer-daemon gave up ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants