We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The NewViewDuration expects float64 for two of its timeout inputs:
NewViewDuration
float64
viewDuration = synchronizer.NewViewDuration( uint64(opts.GetTimeoutSamples()), float64(opts.GetInitialTimeout().AsDuration().Nanoseconds())/float64(time.Millisecond), float64(opts.GetMaxTimeout().AsDuration().Nanoseconds())/float64(time.Millisecond), float64(opts.GetTimeoutMultiplier()), )
We should write a test for the ViewDuration implementation and change the signature from this:
ViewDuration
func NewViewDuration(sampleSize uint64, startTimeout, maxTimeout, multiplier float64) ViewDuration {
To this:
func NewViewDuration(sampleSize uint64, multiplier float64, startTimeout, maxTimeout time.Duration) ViewDuration {
The text was updated successfully, but these errors were encountered:
AlanRostem
When branches are created from issues, their pull requests are automatically linked.
The
NewViewDuration
expectsfloat64
for two of its timeout inputs:We should write a test for the
ViewDuration
implementation and change the signature from this:To this:
The text was updated successfully, but these errors were encountered: