groupName doesnt group if existing PR is open

[breneckd]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Github

Please tell us more about your question or problem

When using groupName to group packages, if a PR is already open it seems that future pkgs will not group until that PR is merged.

I believe this occurs because the groupName has no dynamic value and therefore if it already exists it cannot create a new PR with the same groupname.

Ideally if the PR is still open, on the next run future pkgs will get aggregated into the same PR or we should be able to add a dynamic unique identifier so pkgs are also always aggregated but will go in separate PRs if they are raised at different times.

This issue was seen when a groupName'd PR was already raised, and in the renovate dashboard the rate limited PRs that should fall under the groupName wanted to be created as separate PRs.

Logs (if relevant)

An example from renovate dashboard (fields replaced) where groupName has been configured like so:

    {
      "groupName": "some/pkg (patch)",
      "matchManagers": ["gomod"],
      "matchPackageNames": [
        "github.com/some/pkg/*"
      ],
      "matchUpdateTypes": [
        "patch",
      ],
      "schedule": ["on monday at 9pm"],
    },

Update some/pkg (patch)

Update module github.com/some/foo-api from v0.0.286 to v0.0.309

Update module github.com/some/pkg/jwtauth/v2 from v2.4.9 to v2.4.10

Update module github.com/some/pkg/log/foolog from v0.12.16 to v0.12.17

Update module github.com/some/pkg/log/foo2log from v0.6.5 to v0.6.6

Update module github.com/some/pkg/monitoring/fooattributes from v0.6.16 to v0.6.17

Update module github.com/some/pkg/monitoring/extractor/fooevents from v0.4.11 to v0.4.12

All of these fall under the group since they are all some/pkg and all patch versions so they should be all grouped into the first one that is listed

[github-actions[bot]]

Hi there,

A maintainer decided this is not a bug, and behaving as designed. The maintainer will explain why this behavior is correct. To avoid confusing future readers, we will close this Discussion.

We want Bug-type Discussions to be about things that we rate as bugs. For more details, please read our development docs about bug handling.

If this bug report makes you think of an idea for a new feature, or how to improve a current feature, feel free to create a new Suggest an Idea Discussion.

Thanks, the Renovate team

[rarkins]

Your glob pattern doesn't match the /. Test out your patterns on https://www.digitalocean.com/community/tools/glob