Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pprof.Trace() does not implemented golang v1.4.2 #14

Closed
evalphobia opened this issue Jul 30, 2015 · 3 comments
Closed

pprof.Trace() does not implemented golang v1.4.2 #14

evalphobia opened this issue Jul 30, 2015 · 3 comments
Labels
status-accepted type-bug
Milestone
Backlog

Comments

@evalphobia
Copy link

pprof.Trace() seems to be not implemented yet v1.4.2 (pprof)

so when use this module, I got error below

github.com/revel/modules/pprof/app/controllers/pprof.go:34: undefined: "net/http/pprof".Trace

pprof.Trace() is merged on Jan 29, 2015
It is convenient to remove PprofHandler.Trace() untill this feature supported on the next stable Go version (v1.4.3 or v1.5?).
@evalphobia evalphobia changed the title pprof.Trace() does not implemented v1.4.2 pprof.Trace() does not implemented golang v1.4.2 Jul 30, 2015
@brendensoares
Copy link
Member

@evalphobia could you submit a PR with your proposed changes?

@notzippy notzippy added this to the v0.14 milestone Mar 13, 2017
@notzippy notzippy modified the milestones: v0.15, v0.14 Mar 23, 2017
@notzippy
Copy link
Contributor

See #20 as well

@shawncatz shawncatz modified the milestones: v0.15, v0.16 May 7, 2017
@notzippy notzippy modified the milestones: v0.17, v0.16 May 31, 2017
@notzippy notzippy modified the milestones: Backlog, v0.17 Jul 12, 2017
@notzippy
Copy link
Contributor

It is implemented in go1.6

notzippy pushed a commit to notzippy/revel-modules that referenced this issue Oct 24, 2017
@shawncatz
Merge pull request revel#14 from pedromorgan/viewargs
f5d1af6 
change RenderArgs to ViewArgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status-accepted type-bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@brendensoares @notzippy @shawncatz @evalphobia