Skip to content

Commit b843ff5

Browse files
author
Shahak Yosef
committed
Merged PR 139689: Reduce number of eslint errors
There are currently about 2000 eslint warnings when running gulp build which slows the build time. This PR reduces that number to about 60 by doing the following things; - Run the automatic eslint fix - Ignore the test folder - Ignore several noisy rules - Fix imports Please let me know of any non-trivial change in this PR so I can revert it and make this PR simpler and safer. I recommend reviewing this with `Show and diff white space` unchecked
1 parent 7aafa62 commit b843ff5

22 files changed

+755
-682
lines changed

.eslintignore

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Task 512388: Fix eslint warnings and errors in tests
2+
test/*

.eslintrc.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ module.exports = {
9090
}
9191
}
9292
],
93-
"@typescript-eslint/member-ordering": "warn",
94-
"@typescript-eslint/naming-convention": "warn",
93+
"@typescript-eslint/member-ordering": "off",
94+
"@typescript-eslint/naming-convention": "off",
9595
"@typescript-eslint/no-array-constructor": "warn",
9696
"@typescript-eslint/no-empty-function": "warn",
9797
"@typescript-eslint/no-empty-interface": "warn",
@@ -112,7 +112,7 @@ module.exports = {
112112
"@typescript-eslint/no-unnecessary-type-assertion": "warn",
113113
"@typescript-eslint/no-unsafe-assignment": "warn",
114114
"@typescript-eslint/no-unsafe-call": "warn",
115-
"@typescript-eslint/no-unsafe-member-access": "warn",
115+
"@typescript-eslint/no-unsafe-member-access": "off",
116116
"@typescript-eslint/no-unsafe-return": "warn",
117117
"@typescript-eslint/no-unused-expressions": "warn",
118118
"@typescript-eslint/no-unused-vars": "warn",
@@ -122,7 +122,7 @@ module.exports = {
122122
"@typescript-eslint/prefer-for-of": "warn",
123123
"@typescript-eslint/prefer-function-type": "warn",
124124
"@typescript-eslint/prefer-namespace-keyword": "warn",
125-
"@typescript-eslint/prefer-regexp-exec": "warn",
125+
"@typescript-eslint/prefer-regexp-exec": "off",
126126
"@typescript-eslint/quotes": [
127127
"off",
128128
{
@@ -176,7 +176,6 @@ module.exports = {
176176
"Boolean",
177177
"boolean",
178178
"Undefined",
179-
"undefined"
180179
],
181180
"id-match": "warn",
182181
"import/order": "warn",
@@ -223,7 +222,7 @@ module.exports = {
223222
"warn",
224223
"never"
225224
],
226-
"prefer-arrow/prefer-arrow-functions": "warn",
225+
"prefer-arrow/prefer-arrow-functions": "off",
227226
"prefer-const": "warn",
228227
"prefer-rest-params": "warn",
229228
"quote-props": [

0 commit comments

Comments
 (0)