Skip to content

Commit e7e8ed9

Browse files
author
Shahak Yosef
committed
Merged PR 229897: Remove karma-coverage dependency
Remove karma-coverage dependency because it causes build pipeline to fail and doesn't add enough value. ![ss.png](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/1dd63332-e003-46a3-ac6f-70213a1bcc2e/pullRequests/229897/attachments/ss.png)
1 parent ca1f6ae commit e7e8ed9

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

karma.conf.js

+1-9
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module.exports = function (config) {
2323
{ pattern: './test/**/*.html', served: true, included: false }
2424
],
2525
exclude: [],
26-
reporters: argv.chrome ? ['coverage', 'kjhtml'] : ['spec', 'coverage', 'junit'],
26+
reporters: argv.chrome ? ['kjhtml'] : ['spec', 'junit'],
2727
autoWatch: true,
2828
browsers: [browserName],
2929
browserNoActivityTimeout: 300000,
@@ -33,7 +33,6 @@ module.exports = function (config) {
3333
'karma-jasmine',
3434
'karma-spec-reporter',
3535
'karma-phantomjs-launcher',
36-
'karma-coverage',
3736
'karma-jasmine-html-reporter',
3837
'karma-junit-reporter'
3938
],
@@ -43,13 +42,6 @@ module.exports = function (config) {
4342
flags: flags.concat("--no-sandbox", "--window-size=800,800"),
4443
},
4544
},
46-
preprocessors: { './tmp/**/*.js': ['coverage'] },
47-
coverageReporter: {
48-
reporters: [
49-
{ type: 'html' },
50-
{ type: 'text-summary' }
51-
]
52-
},
5345
junitReporter: {
5446
outputDir: 'tmp',
5547
outputFile: 'testresults.xml',

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
"json-loader": "^0.5.4",
6565
"karma": "6.3.5",
6666
"karma-chrome-launcher": "^3.1.0",
67-
"karma-coverage": "^2.0.3",
6867
"karma-firefox-launcher": "^1.2.0",
6968
"karma-jasmine": "4.0.1",
7069
"karma-jasmine-html-reporter": "1.7.0",

0 commit comments

Comments
 (0)