-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS X build of arm fails because of bracket-depth #11
Comments
Actually, even with that it fails:
|
After at least 30 builds trying to figure this out, I went back to a patch that should be almost like the one in the first comment, so no idea why that didn't work. Anyway, added to the OS X PR |
I don't think straight setting of CXXFLAGS here is right because that will either override, or be overridden by, any user settings of CXXFLAGS. In particular possibly-desirable things like CXXFLAGS="-g0 -O2" or "-g0 -Os" will clash with it. There probably should be some approach to constructively building these up and just setting them once, or some trick to poke at and modify an existing setting... |
Agreed, it's not optimal at all. But I honestly looked for cleaner ways, and after many cycles I have to say that I can't find any. Not that it means anything except that I'm not worth much at writing Makefiles :) |
Realized I could just append it to CXX. It composes well (no overriding issues), and it even makes more sense, since the option is needed only with that CXX, and it's needed to make it a functional CXX. #9 now has that version of the patch and builds cleanly for me. |
On OS X the arm build only works with
Can you add this by default?
There's a bug in LLVM for this: https://llvm.org/bugs/show_bug.cgi?id=19650
The text was updated successfully, but these errors were encountered: