Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling normalization causes an error #47

Closed
eitanrich opened this issue Sep 14, 2020 · 1 comment
Closed

Enabling normalization causes an error #47

eitanrich opened this issue Sep 14, 2020 · 1 comment

Comments

@eitanrich
Copy link

It looks like target and pred should be replaced with in0 and in1.

PerceptualSimilarity/lpips/lpips.py

Line 83 in a1188a3

target = 2 * target - 1

To reproduce: set normalize=True when calling the loss function.
@richzhang
Copy link
Owner

You're right, fixed. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richzhang @eitanrich