Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPIPS source comments are reversed? #77

Closed
torridgristle opened this issue Sep 10, 2021 · 3 comments
Closed

LPIPS source comments are reversed? #77

torridgristle opened this issue Sep 10, 2021 · 3 comments

Comments

@torridgristle
Copy link

torridgristle commented Sep 10, 2021

At

pnet_tune
[False] tune the base/trunk network
[True] keep base/trunk frozen
it seems like line 53 should be [False] and line 54 should be [True] since enabling it would enable grad, but the comment says that setting it to true would freeze it.

@richzhang
Copy link
Owner

Thanks, you're right, it was mixed up. I switched them: https://github.com/richzhang/PerceptualSimilarity/blob/master/lpips/lpips.py#L52.

@torridgristle
Copy link
Author

It may be pedantic, but the order should probably be True, False in order to match the others. Personally I tend to expect patterns in things and I may assume the first one is true and the second is false even if it's explicitly labelled the other way around, and I reckon other folks could make that same mistake when glossing over it.

@richzhang
Copy link
Owner

Thanks, the default parameters are listed first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants