-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPIPS source comments are reversed? #77
Comments
Thanks, you're right, it was mixed up. I switched them: https://github.com/richzhang/PerceptualSimilarity/blob/master/lpips/lpips.py#L52. |
It may be pedantic, but the order should probably be True, False in order to match the others. Personally I tend to expect patterns in things and I may assume the first one is true and the second is false even if it's explicitly labelled the other way around, and I reckon other folks could make that same mistake when glossing over it. |
Thanks, the default parameters are listed first |
At
PerceptualSimilarity/lpips/lpips.py
Lines 52 to 54 in ecfae6f
The text was updated successfully, but these errors were encountered: