forked from pingcap/tidb
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcompact_table_test.go
975 lines (903 loc) · 36 KB
/
compact_table_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
// Copyright 2022 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package executor_test
import (
"context"
"fmt"
"regexp"
"sync"
"testing"
"time"
"github.com/pingcap/errors"
"github.com/pingcap/kvproto/pkg/kvrpcpb"
"github.com/pingcap/kvproto/pkg/metapb"
"github.com/pingcap/tidb/store/mockstore"
"github.com/pingcap/tidb/store/mockstore/unistore"
"github.com/pingcap/tidb/testkit"
"github.com/stretchr/testify/require"
"github.com/tikv/client-go/v2/testutils"
"github.com/tikv/client-go/v2/tikv"
"github.com/tikv/client-go/v2/tikvrpc"
"go.uber.org/atomic"
)
// withMockTiFlash sets the mockStore to have N TiFlash stores (naming as tiflash0, tiflash1, ...).
func withMockTiFlash(nodes int) mockstore.MockTiKVStoreOption {
return mockstore.WithMultipleOptions(
mockstore.WithClusterInspector(func(c testutils.Cluster) {
mockCluster := c.(*unistore.Cluster)
_, _, region1 := mockstore.BootstrapWithSingleStore(c)
tiflashIdx := 0
for tiflashIdx < nodes {
store2 := c.AllocID()
peer2 := c.AllocID()
addr2 := fmt.Sprintf("tiflash%d", tiflashIdx)
mockCluster.AddStore(store2, addr2, &metapb.StoreLabel{Key: "engine", Value: "tiflash"})
mockCluster.AddPeer(region1, store2, peer2)
tiflashIdx++
}
}),
mockstore.WithStoreType(mockstore.EmbedUnistore),
)
}
func TestCompactUnknownTable(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
err := tk.ExecToErr(`alter table test compact tiflash replica;`)
require.Equal(t, "[planner:1046]No database selected", err.Error())
err = tk.ExecToErr(`alter table test.foo compact tiflash replica;`)
require.Equal(t, "[schema:1146]Table 'test.foo' doesn't exist", err.Error())
tk.MustExec("use test")
err = tk.ExecToErr(`alter table bar compact;`)
require.Equal(t, "[schema:1146]Table 'test.bar' doesn't exist", err.Error())
}
func TestCompactTableNoTiFlashReplica(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact skipped: no tiflash replica in the table`,
))
tk.MustExec(`alter table test.t compact;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact skipped: no tiflash replica in the table`,
))
tk = testkit.NewTestKit(t, store)
tk.MustExec(`alter table test.t compact;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact skipped: no tiflash replica in the table`,
))
}
func TestCompactTableNoPartition(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
_, err := tk.Exec("alter table t compact partition p1,p2 tiflash replica;")
require.NotNil(t, err)
require.Equal(t, "table:t is not a partition table, but user specify partition name list:[p1 p2]", err.Error())
}
func TestCompactTablePartitionInvalid(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec(`
CREATE TABLE t (
id INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
fname VARCHAR(25) NOT NULL,
lname VARCHAR(25) NOT NULL,
store_id INT NOT NULL,
department_id INT NOT NULL
)
PARTITION BY RANGE(id) (
PARTITION p0 VALUES LESS THAN (5),
PARTITION p1 VALUES LESS THAN (10),
PARTITION p2 VALUES LESS THAN (15),
PARTITION p3 VALUES LESS THAN MAXVALUE
);
`)
_, err := tk.Exec("alter table t compact partition p1,p2,p4 tiflash replica;")
require.NotNil(t, err)
require.Equal(t, "[table:1735]Unknown partition 'p4' in table 't'", err.Error())
}
func TestCompactTableTooBusy(t *testing.T) {
mocker := newCompactRequestMocker(t)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrTooManyPendingTasks{}},
}, nil
})
defer mocker.RequireAllHandlersHit()
store := testkit.CreateMockStore(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact on store tiflash0 failed: store is too busy`,
))
}
func TestCompactTableInProgress(t *testing.T) {
mocker := newCompactRequestMocker(t)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrCompactInProgress{}},
}, nil
})
defer mocker.RequireAllHandlersHit()
store := testkit.CreateMockStore(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact on store tiflash0 failed: table is compacting in progress`,
))
}
func TestCompactTableInternalError(t *testing.T) {
mocker := newCompactRequestMocker(t)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrInvalidStartKey{}},
}, nil
})
defer mocker.RequireAllHandlersHit()
store := testkit.CreateMockStore(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact on store tiflash0 failed: internal error (check logs for details)`,
))
}
// TestCompactTableNoRemaining: Returns NoRemaining for request #1.
func TestCompactTableNoRemaining(t *testing.T) {
mocker := newCompactRequestMocker(t)
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
mocker.RequireAllHandlersHit()
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
tk = testkit.NewTestKit(t, store)
tk.MustExec(`alter table test.t compact;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
mocker.RequireAllHandlersHit()
}
// TestCompactTableHasRemaining: Returns HasRemaining=true for request #1 and #2, returns HasRemaining=false for request #3.
func TestCompactTableHasRemaining(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Equal(t, []byte{0xFF}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0x20},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Equal(t, []byte{0xFF, 0x20}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0xA0},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableErrorInHalfway: Returns error for request #2.
func TestCompactTableErrorInHalfway(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, _ := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
return &kvrpcpb.CompactResponse{
HasRemaining: false,
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrTooManyPendingTasks{}},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows(
`Warning 1105 compact on store tiflash0 failed: store is too busy`,
))
}
// TestCompactTableNoRemainingMultipleTiFlash: 2 TiFlash stores, both returns NoRemaining for request #1.
func TestCompactTableNoRemainingMultipleTiFlash(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(2), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash1/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "t")
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, tableID)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableMultipleTiFlash: 2 TiFlash stores.
// Store0 - #1 (remaining=true), #2 (remaining=true), #3 (remaining=false)
// Store1 - #1 (remaining=true), #2 (remaining=false)
func TestCompactTableMultipleTiFlash(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, _ := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(2), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0x20},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF, 0x20}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0xA0},
}, nil
})
mocker.MockFrom(`tiflash1/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xC0, 0xCC}, // Use a different end key as tiflash0
}, nil
})
mocker.MockFrom(`tiflash1/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xC0, 0xCC}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xDD},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableMultipleTiFlashWithError: 3 TiFlash stores.
// Store0 - #1 (remaining=true), #2 (remaining=true), #3 (remaining=false)
// Store1 - #1 (remaining=true), #2 (error)
// Store2 - #1 (error)
func TestCompactTableMultipleTiFlashWithError(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, _ := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(3), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF}, req.StartKey)
time.Sleep(time.Second * 1)
// This request must be returned after store1 and store2 return errors. We should still receive req #3.
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0x20},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF, 0x20}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0xA0},
}, nil
})
mocker.MockFrom(`tiflash1/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xC0, 0xCC},
}, nil
})
mocker.MockFrom(`tiflash1/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xC0, 0xCC}, req.StartKey)
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrTooManyPendingTasks{}},
}, nil
})
mocker.MockFrom(`tiflash2/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrTooManyPendingTasks{}},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Sort().Check(testkit.Rows(
"Warning 1105 compact on store tiflash1 failed: store is too busy",
"Warning 1105 compact on store tiflash2 failed: store is too busy",
))
}
// TestCompactTableWithRangePartition: 1 TiFlash, table has 4 partitions.
// Partition 0: 1 Partials
// Partition 1: 3 Partials
// Partition 2: 1 Partials
// Partition 3: 2 Partials
// There will be 7 requests sent in series.
func TestCompactTableWithRangePartition(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 0)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xCC},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xCC}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#4`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xFF}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0xAA},
}, nil
})
mocker.MockFrom(`tiflash0/#5`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 2)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xAB},
}, nil
})
mocker.MockFrom(`tiflash0/#6`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 3)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xC0},
}, nil
})
mocker.MockFrom(`tiflash0/#7`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 3)
require.Equal(t, []byte{0xC0}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xC1, 0xFF, 0x00},
}, nil
})
tk.MustExec("use test")
tk.MustExec(`
CREATE TABLE employees (
id INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
fname VARCHAR(25) NOT NULL,
lname VARCHAR(25) NOT NULL,
store_id INT NOT NULL,
department_id INT NOT NULL
)
PARTITION BY RANGE(id) (
PARTITION p0 VALUES LESS THAN (5),
PARTITION p1 VALUES LESS THAN (10),
PARTITION p2 VALUES LESS THAN (15),
PARTITION p3 VALUES LESS THAN MAXVALUE
);
`)
tk.MustExec(`alter table employees set tiflash replica 1;`)
tk.MustExec(`alter table employees compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableWithHashPartition: 1 TiFlash, table has 3 partitions (hash partition).
// During compacting the partition, one partition will return failure PhysicalTableNotExist. The remaining partitions should be still compacted.
func TestCompactTableWithHashPartitionAndOnePartitionFailed(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 0)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xA0},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xA0}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrPhysicalTableNotExist{}}, // For example, may be this partition got dropped
}, nil
})
mocker.MockFrom(`tiflash0/#4`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 2)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xCD},
}, nil
})
tk.MustExec("use test")
tk.MustExec(`
CREATE TABLE employees (
id INT NOT NULL,
fname VARCHAR(30),
lname VARCHAR(30),
hired DATE NOT NULL DEFAULT '1970-01-01',
separated DATE DEFAULT '9999-12-31',
job_code INT,
store_id INT
)
PARTITION BY HASH(store_id)
PARTITIONS 3;
`)
tk.MustExec(`alter table employees set tiflash replica 1;`)
tk.MustExec(`alter table employees compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableWithTiFlashDown: 2 TiFlash stores.
// Store0 - #1 (remaining=true, takes 3s), #2 (remaining=false)
// Store1 - #1 (remaining=true), #2+ (down)
func TestCompactTableWithTiFlashDown(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, _ := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(2), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
time.Sleep(time.Second * 3)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0x00, 0xAA},
}, nil
})
mocker.MockFrom(`^tiflash1/#1$`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xA0},
}, nil
})
mocker.MockFrom(`tiflash1/#`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
// For #2~#N requests, always return network errors
return nil, errors.New("Bad network")
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Sort().Check(testkit.Rows(
"Warning 1105 compact on store tiflash1 failed: Bad network",
))
}
// TestCompactTableWithSpecifiedRangePartition: 1 TiFlash, table has 4 partitions.
// only compact Partition 1: 3 Partials
// There will be 3 requests sent in series.
func TestCompactTableWithSpecifiedRangePartition(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xCC},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xCC}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xFF}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0xAA},
}, nil
})
tk.MustExec("use test")
tk.MustExec(`
CREATE TABLE employees (
id INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
fname VARCHAR(25) NOT NULL,
lname VARCHAR(25) NOT NULL,
store_id INT NOT NULL,
department_id INT NOT NULL
)
PARTITION BY RANGE(id) (
PARTITION p0 VALUES LESS THAN (5),
PARTITION p1 VALUES LESS THAN (10),
PARTITION p2 VALUES LESS THAN (15),
PARTITION p3 VALUES LESS THAN MAXVALUE
);
`)
tk.MustExec(`alter table employees set tiflash replica 1;`)
tk.MustExec(`alter table employees compact partition p1 tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableWithSpecifiedHashPartition: 1 TiFlash, table has 3 partitions (hash partition).
// only compact p1, p2
// During compacting the partition, one partition will return failure PhysicalTableNotExist. The remaining partitions should be still compacted.
func TestCompactTableWithSpecifiedHashPartitionAndOnePartitionFailed(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, do := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(1), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xA0},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 1)
require.Equal(t, []byte{0xA0}, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
Error: &kvrpcpb.CompactError{Error: &kvrpcpb.CompactError_ErrPhysicalTableNotExist{}}, // For example, may be this partition got dropped
}, nil
})
mocker.MockFrom(`tiflash0/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
tableID := do.MustGetTableID(t, "test", "employees")
pid := do.MustGetPartitionAt(t, "test", "employees", 2)
require.Empty(t, req.StartKey)
require.EqualValues(t, req.PhysicalTableId, pid)
require.EqualValues(t, req.LogicalTableId, tableID)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xCD},
}, nil
})
tk.MustExec("use test")
tk.MustExec(`
CREATE TABLE employees (
id INT NOT NULL,
fname VARCHAR(30),
lname VARCHAR(30),
hired DATE NOT NULL DEFAULT '1970-01-01',
separated DATE DEFAULT '9999-12-31',
job_code INT,
store_id INT
)
PARTITION BY HASH(store_id)
PARTITIONS 3;
`)
tk.MustExec(`alter table employees set tiflash replica 1;`)
tk.MustExec(`alter table employees compact PARTITION p1,p2 tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// TestCompactTableWithTiFlashDownAndRestore: 2 TiFlash stores.
// Store0 - #1 (remaining=true, takes 3s), #2 (remaining=false)
// Store1 - #1 (remaining=true), #2 (down), #3 (restored, remaining=false)
func TestCompactTableWithTiFlashDownAndRestore(t *testing.T) {
mocker := newCompactRequestMocker(t)
defer mocker.RequireAllHandlersHit()
store, _ := testkit.CreateMockStoreAndDomain(t, withMockTiFlash(2), mocker.AsOpt())
tk := testkit.NewTestKit(t, store)
mocker.MockFrom(`tiflash0/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
time.Sleep(time.Second * 3)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
mocker.MockFrom(`tiflash0/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xFF}, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF, 0x00, 0xAA},
}, nil
})
mocker.MockFrom(`tiflash1/#1`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Empty(t, req.StartKey)
return &kvrpcpb.CompactResponse{
HasRemaining: true,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xA0},
}, nil
})
mocker.MockFrom(`tiflash1/#2`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xA0}, req.StartKey)
time.Sleep(time.Second * 1)
return nil, errors.New("Bad Network")
})
mocker.MockFrom(`tiflash1/#3`, func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error) {
require.Equal(t, []byte{0xA0}, req.StartKey) // The same request should be sent again.
return &kvrpcpb.CompactResponse{
HasRemaining: false,
CompactedStartKey: []byte{},
CompactedEndKey: []byte{0xFF},
}, nil
})
tk.MustExec("use test")
tk.MustExec("create table t(a int)")
tk.MustExec(`alter table t set tiflash replica 1;`)
tk.MustExec(`alter table t compact tiflash replica;`)
tk.MustQuery(`show warnings;`).Check(testkit.Rows())
}
// Code below are helper utilities for the test cases.
type compactClientHandler struct {
matcher *regexp.Regexp
matcherString string
fn func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error)
hit atomic.Bool
}
type compactRequestMocker struct {
tikv.Client
t *testing.T
handlers []*compactClientHandler
mu sync.Mutex
receivedRequestsOfAddr map[string]int
}
func (client *compactRequestMocker) SendRequest(ctx context.Context, addr string, req *tikvrpc.Request, timeout time.Duration) (*tikvrpc.Response, error) {
if req.Type == tikvrpc.CmdCompact {
client.mu.Lock()
client.receivedRequestsOfAddr[addr]++
handlerKey := fmt.Sprintf("%s/#%d", addr, client.receivedRequestsOfAddr[addr])
client.mu.Unlock()
for _, handler := range client.handlers {
if handler.matcher.MatchString(handlerKey) {
handler.hit.Store(true)
resp, err := handler.fn(req.Compact())
if err != nil {
return nil, err
}
return &tikvrpc.Response{Resp: resp}, nil
}
}
// If we enter here, it means no handler is matching. We should fail!
require.Fail(client.t, fmt.Sprintf("Received request %s but no matching handler, maybe caused by unexpected number of requests?", handlerKey))
}
return client.Client.SendRequest(ctx, addr, req, timeout)
}
func newCompactRequestMocker(t *testing.T) *compactRequestMocker {
return &compactRequestMocker{
handlers: make([]*compactClientHandler, 0),
receivedRequestsOfAddr: make(map[string]int),
t: t,
}
}
func (client *compactRequestMocker) MockFrom(matchPattern string, fn func(req *kvrpcpb.CompactRequest) (*kvrpcpb.CompactResponse, error)) *compactRequestMocker {
m := regexp.MustCompile(matchPattern)
client.handlers = append(client.handlers, &compactClientHandler{
matcher: m,
matcherString: matchPattern,
fn: fn,
hit: atomic.Bool{},
})
return client
}
func (client *compactRequestMocker) RequireAllHandlersHit() {
for _, handler := range client.handlers {
if !handler.hit.Load() {
require.Fail(client.t, fmt.Sprintf("Request handler %s did not hit, maybe caused by request was missing?", handler.matcherString))
}
}
}
func (client *compactRequestMocker) AsOpt() mockstore.MockTiKVStoreOption {
return mockstore.WithClientHijacker(func(kvClient tikv.Client) tikv.Client {
client.Client = kvClient
return client
})
}