Fixed small leak with info().

nicolasff · nicolasff · commit 5d8839f15e42 · 2012-01-30T20:43:09.000Z
Thanks to @kotas for reporting and @chobie for fixing. This closes GitHub issue phpredis#125.
diff --git a/library.c b/library.c
@@ -475,9 +475,7 @@ PHPAPI void redis_info_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_s
     IF_MULTI_OR_PIPELINE() {
         add_next_index_zval(z_tab, z_multi_result);
     } else {
-	    *return_value = *z_multi_result;
-	    zval_copy_ctor(return_value);
-	    efree(z_multi_result);
+        RETVAL_ZVAL(z_multi_result, 0, 1);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -475,9 +475,7 @@ PHPAPI void redis_info_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_s`
`475`	`475`	`IF_MULTI_OR_PIPELINE() {`
`476`	`476`	`add_next_index_zval(z_tab, z_multi_result);`
`477`	`477`	`} else {`
`478`		`- return_value = z_multi_result;`
`479`		`- zval_copy_ctor(return_value);`
`480`		`- efree(z_multi_result);`
	`478`	`+ RETVAL_ZVAL(z_multi_result, 0, 1);`
`481`	`479`	`}`
`482`	`480`	`}`
`483`	`481`