Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wired-tabs are not working as of the latest release #146

Closed
edyu opened this issue May 14, 2020 · 4 comments
Closed

Wired-tabs are not working as of the latest release #146

edyu opened this issue May 14, 2020 · 4 comments

Comments

@edyu
Copy link

edyu commented May 14, 2020

I first tried with some nested elements so I thought maybe that's the problem but even when I use the exact same example index.html for wired-tabs, I'm seeing the same problem.
tab_problem

@edyu
Copy link
Author

edyu commented May 14, 2020

Note that I also tried out other elements such as wired-label, wired-button, wired-search-input etc and they all work fine.

@apennamen
Copy link
Contributor

Hello,
I was able to reproduce the issue and this is a weeeeeeird one...
The source code that is printed in the page is the one of the "repeat" directive (wired-tabs is the only component that uses it, that's why you won't have the issue with the others).

Apparently it doesn't append after a build phase, for example with rollup (I have to confirm that).
No idea where it comes from...

@pshihn
Copy link
Contributor

pshihn commented Jun 20, 2020

v2.1.1 does not rely on repeat any more.
Try it now.

If you could link to a reproducible sample it would be great.
Also sorry for the late response

@pshihn
Copy link
Contributor

pshihn commented Jun 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants