Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Careless Accepts SIGI=0 #183

Open
kmdalton opened this issue Feb 12, 2025 · 2 comments
Open

Careless Accepts SIGI=0 #183

kmdalton opened this issue Feb 12, 2025 · 2 comments
Assignees

Comments

@kmdalton
Copy link
Member

kmdalton commented Feb 12, 2025

Careless actually runs and produces (pathological) output when there are SIGI values of 0 in the input. There should be a way to deal with this by either

  1. refusing to run
  2. purging entries with SIGI<= 0
  3. setting SIGI = maximum(SIGI, np.abs(I) / max_isigi)

I have a slight preference for (3), because i think in general we should discount reported I/SIGI values that are greater than about 100 or so.

@kmdalton kmdalton self-assigned this Feb 12, 2025
@PrinceWalnut
Copy link
Member

(3) I'm guessing you meant np.abs(I) / max_isigi? I think this might be worth adding a flag for allowing that in cases of known low-intensity data, but I would personally prefer (2) with a warning label in the logs.

@kmdalton
Copy link
Member Author

yeah! sorry i meant / not *. i updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants