Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Customization of Full-Screen Card 'expand' and 'close' Labels #833

Open
mhanf opened this issue Oct 13, 2023 · 3 comments
Open

Allow Customization of Full-Screen Card 'expand' and 'close' Labels #833

mhanf opened this issue Oct 13, 2023 · 3 comments

Comments

@mhanf
Copy link

mhanf commented Oct 13, 2023

When using the 'full_screen' parameter of the card function and setting it to TRUE, the tooltip label for the expand button and the subsequent close button label are hardcoded in English as "Expand" and "Close."

It would greatly benefit developers to have the ability to customize these labels. This customization feature would be particularly useful when developing applications in languages other than English.

One way to implement this feature could be to add optional parameters for custom labels when calling the bslib card function.

Thank you for considering this improvement.
Best regards

@gadenbuie
Copy link
Member

Thanks for the issue @mhanf. I agree, the need to customize the language of the label is quite motivating. I'm envisioning that we would provide a full_screen_options() helper that would be accepted by the full_screen argument. This would allow users to provide their own label or icon without us having to add more arguments to card() or value_box().

@mhanf
Copy link
Author

mhanf commented Oct 15, 2023

Thank you, @gadenbuie, for your response. This would be truly ideal. The 'fullscreen' argument has a wide range of use cases, and enabling the 'full_screen_options()' helper would empower developers to utilize it in a broader context.

@serkor1
Copy link

serkor1 commented Mar 27, 2024

@gadenbuie is this in the pipeline, or has it been implementet already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants