Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV no longer included as part of standard library #397

Open
calebhearth opened this issue Apr 9, 2024 · 2 comments
Open

CSV no longer included as part of standard library #397

calebhearth opened this issue Apr 9, 2024 · 2 comments

Comments

@calebhearth
Copy link

As of Ruby 3.3.0, I see this message with tilt installed (as a transient dependency of sassc-rails):

[clip]/.gem/ruby/3.3.0/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38: warning: csv was loaded from the standard library, but will no longer be part
 of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.12 to add csv into its gemspec.

Zeitwerk is doing some autoloading stuff that makes Ruby think it's its fault, but I do see that tilt has a dependency on CSV.

I'm happy to put in a PR for this, but wanted to discuss first since I see 2 options:

  • Leave CSV out as a dependency and update the README section to identify that CSV is no longer part of the Standard Library as of 3.3 / 3.4
  • Add a dependency on CSV to tilt

If you'd like a PR, which direction (or one I'm not thinking of) make more sense to you?

@adam12
Copy link

adam12 commented Apr 9, 2024

It might be worth refiling this over on https://github.com/jeremyevans/tilt, which is now the canonical repo for tilt.

@jeremyevans
Copy link
Contributor

It isn't appropriate to add a dependency on csv to tilt, since csv is optional and not required. Most other libraries you have to already list in the Gemfile separately, so this makes csv more similar to those. I'm not sure it makes sense to add it to the README, but I don't have objections.

Note that tilt upstream is now at https://github.com/jeremyevans/tilt, this repository is no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants