TryFromBorrowedObject for byteslike

Author: youknowone

vm/src/byteslike.rs

@@ -71,9 +71,9 @@ impl ArgBytesLike {
     }
 }
 
-impl TryFromObject for ArgBytesLike {
-    fn try_from_object(vm: &VirtualMachine, obj: PyObjectRef) -> PyResult<Self> {
-        Self::new(vm, &obj)
+impl TryFromBorrowedObject for ArgBytesLike {
+    fn try_from_borrowed_object(vm: &VirtualMachine, obj: &PyObjectRef) -> PyResult<Self> {
+        Self::new(vm, obj)
     }
 }
 
@@ -122,9 +122,9 @@ impl ArgMemoryBuffer {
     }
 }
 
-impl TryFromObject for ArgMemoryBuffer {
-    fn try_from_object(vm: &VirtualMachine, obj: PyObjectRef) -> PyResult<Self> {
-        Self::new(vm, &obj)
+impl TryFromBorrowedObject for ArgMemoryBuffer {
+    fn try_from_borrowed_object(vm: &VirtualMachine, obj: &PyObjectRef) -> PyResult<Self> {
+        Self::new(vm, obj)
     }
 }
 

wasm/lib/src/convert.rs

@@ -8,7 +8,9 @@ use rustpython_vm::exceptions::PyBaseExceptionRef;
 use rustpython_vm::function::FuncArgs;
 use rustpython_vm::VirtualMachine;
 use rustpython_vm::{exceptions, py_serde};
-use rustpython_vm::{ItemProtocol, PyObjectRef, PyResult, PyValue, TryFromObject, TypeProtocol};
+use rustpython_vm::{
+    ItemProtocol, PyObjectRef, PyResult, PyValue, TryFromBorrowedObject, TypeProtocol,
+};
 
 use crate::js_module;
 use crate::vm_class::{stored_vm_from_wasm, WASMVirtualMachine};
@@ -139,7 +141,7 @@ pub fn py_to_js(vm: &VirtualMachine, py_obj: PyObjectRef) -> JsValue {
         }
     }
 
-    if let Ok(bytes) = ArgBytesLike::try_from_object(vm, py_obj.clone()) {
+    if let Ok(bytes) = ArgBytesLike::try_from_borrowed_object(vm, &py_obj) {
         bytes.with_ref(|bytes| unsafe {
             // `Uint8Array::view` is an `unsafe fn` because it provides
             // a direct view into the WASM linear memory; if you were to allocate