-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear performance test times out intermittently on JRuby #1310
Comments
See comments here discussing this failure: #1305 (comment) |
JRuby's perf does not suddenly go non-linear, but this test is occasionally timing out. We will investigate separtely and disable it for now. See #1310
@enebo This exercises our Java-based parser through Ripper. Can you think of any reason why it might occasionally parse slower, other than VM variability issues? |
@headius It is a huge lists of lambdas being called from a single method. Any change in performance in executing the same code I think would be from the JVM deciding to compile stuff (which should happen up front). I would not expect it to be linear from that alone. Your comment (in linked issue) sounds right that they need a warmup cycle to measure linear performance. If that does not explain it then we probably need to generate a histogram and see if there is something weird happening like a growing but removable data structure which is causing a large GC spike. |
The linear timing test "test_read_directive_linear_performance" occasionally times out on JRuby. This does not likely indicate a failure to run the example in linear time as much as it reflects a sensitivity to very short timeouts. Until we fully understand why this test times out intermittently, I will omit it on JRuby.
The timeout failure produces the following output in CI:
The text was updated successfully, but these errors were encountered: