From f6e0e3e69d676e5ab8c393c84e2b735122e34a07 Mon Sep 17 00:00:00 2001
From: Tobias Bieniek <tobias@bieniek.cloud>
Date: Tue, 20 May 2025 20:00:56 +0200
Subject: [PATCH] controllers/site_metadata: Avoid unnecessary allocation

---
 src/controllers/site_metadata.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/controllers/site_metadata.rs b/src/controllers/site_metadata.rs
index 558e740d915..cf2248c1cf5 100644
--- a/src/controllers/site_metadata.rs
+++ b/src/controllers/site_metadata.rs
@@ -29,12 +29,12 @@ pub struct MetadataResponse<'a> {
 pub async fn get_site_metadata(state: AppState) -> impl IntoResponse {
     let read_only = state.config.db.are_all_read_only();
 
-    let deployed_sha =
-        dotenvy::var("HEROKU_SLUG_COMMIT").unwrap_or_else(|_| String::from("unknown"));
+    let deployed_sha = dotenvy::var("HEROKU_SLUG_COMMIT");
+    let deployed_sha = deployed_sha.as_deref().unwrap_or("unknown");
 
     Json(MetadataResponse {
-        deployed_sha: &deployed_sha,
-        commit: &deployed_sha,
+        deployed_sha,
+        commit: deployed_sha,
         read_only,
     })
     .into_response()