Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP references cover into and from #18655

Closed
dev-ardi opened this issue Dec 10, 2024 · 2 comments
Closed

LSP references cover into and from #18655

dev-ardi opened this issue Dec 10, 2024 · 2 comments
Labels
A-ide general IDE features C-feature Category: feature request

Comments

@dev-ardi
Copy link

dev-ardi commented Dec 10, 2024

Right now they don't really do much:

struct A;
struct B;
impl From<A> for B {
    fn from(_: A) -> B {
        B
    }
}

fn foo() -> B {
    A.into()
}

I would expect LSP references to show up in:

  • A: Show the .into() call. It works for B
  • from: show the .into() call, also show up in "LSP incoming calls"

I would also expect this to work on ? after it's been desugared.

@dev-ardi dev-ardi added the C-feature Category: feature request label Dec 10, 2024
@roife
Copy link
Member

roife commented Dec 25, 2024

We might need to implement #18316 first.

@roife roife added the A-ide general IDE features label Dec 25, 2024
@Veykril
Copy link
Member

Veykril commented Dec 26, 2024

That does not sound like something the references call should do to me, as raised #18316 would cover this more correctly.

@Veykril Veykril closed this as completed Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ide general IDE features C-feature Category: feature request
Projects
None yet
Development

No branches or pull requests

3 participants