"Extract into constant / variable / static" improvements

[lnicola]

• in some cases like Extract into const #14886 (short string), we could use the string to name the constant or static instead of key / KEY
• I think the code tries to put the cursor on the new item, but it doesn't work for me:

CC @Giga-Bowser, #14886

[Giga-Bowser]

• I think the code tries to put the cursor on the new item, but it doesn't work for me

Is this rust-analyzer running through one of the launch.json configurations like Run Extension (Release Build)? I seem to remember having some issues with placeholder snippets/tabstops when using those, and I meant to go back and investigate that at some point.

[lnicola]

No, I did cargo xtask install and restarted VS.

[Giga-Bowser]

After some careful git bisecting, this bug was caused by the change made to editors/code/src/client.ts in bac0ed5. @Veykril are we safe to revert that change?

[Veykril]

Oh no, I thought I've fixed that again. We should definitely revert that change, as it was an accident.