-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Closed
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Description
Location
File::lock
, File::try_lock
, File::lock_shared
, File::try_lock_shared
Summary
The recently stabilized lock-related methods for File
have some grammatical errors.
1. All of the methods
If this file handle/descriptor, or a clone of it, already holds an lock [...]
Since lock starts with a consonant, the preceding article should be a.
Additionally, all of the methods refer to
acquire a [...] lock on the file
As I'm not a native english speaker, I'm not sure if this is correct, but it seems to me that
acquire a [...] lock to the file
is much more natural.
2. File::lock
and File::try_lock
If the file not open for writing
should be
If the file is not open for writing
Metadata
Metadata
Assignees
Labels
A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.