You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We started using cfg_aliases! in #2586, which I guess makes sense from a maintenance perspective (though I'll admit, I'm somewhat against it because it feels like an unnecessary dependency and adds build time).
However, its usage has crept into our examples, which I believe to be a bad idea, as the user will not be having those cfgs, meaning that they cannot directly copy our example code.
So I propose using the normal target_os = "macos"/feature = "x11" values in there.
The text was updated successfully, but these errors were encountered:
One more reason to get rid of config_aliases is that it doesn't work without Cargo, because it relies on all the CARGO_CFG_TARGET_FAMILY (etc) flags being set.
I was writing code to generate fixups for reindeer, and ended up making a recursive evaluator. If it saves you a few minutes, there you go.
We started using
cfg_aliases!
in #2586, which I guess makes sense from a maintenance perspective (though I'll admit, I'm somewhat against it because it feels like an unnecessary dependency and adds build time).However, its usage has crept into our examples, which I believe to be a bad idea, as the user will not be having those
cfg
s, meaning that they cannot directly copy our example code.So I propose using the normal
target_os = "macos"
/feature = "x11"
values in there.The text was updated successfully, but these errors were encountered: