How to execute a task in all members + workspace root?

[augustocdias]

So my project structure is the following.

ROOT
|_ Cargo.toml
|_ Makefile.toml
|_ src
|_ member1
   |_ Cargo.toml
   |_ src
|_ member2
   |_ Cargo.toml
   |_ src

so my root Cargo.toml contains something like this:

[package]
name = "binary-name"
version = "0.1.0"
edition = "2018"

[workspace]
members = [
    'member1',
    'member2'
]

[dependencies]
member1 = {path = "./member1"}
member2 = {path = "./member2"}

On my Makefile.toml I have

[env]
CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = true

[tasks.lint]
script = '''
cargo fmt -- --emit=files
cargo clippy -- -D warnings
'''

When I run cargo make lint it is running only in the members and not in the root. Is there a way to make it run in the members and in the root?

[augustocdias]

I came up with the following that works, but I'm 100% unsatisfied with... It is too verbose.

[env]
CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = true

[tasks.lint]
dependencies = ["lint-root", "lint-members"]
workspace = false

[tasks.lint-base]
script = '''
cargo fmt -- --emit=files
cargo clippy -- -D warnings
'''

[tasks.lint-members]
run_task = { name = "lint-base", fork = true }

[tasks.lint-root]
run_task = { name = "lint-base" }
workspace = false

If there's a better way to do it please share. Otherwise I suggest to open an issue to make it easier to express this in a simpler way.

It is interesting that the "default" tasks behaves as expected without any change:

[tasks.test]
command = "cargo"
args = ["test", "--", "${@}"]

When I run this on my setup it executes the tests in all members and then in the root directory.

[sagiegurari]

strange, i could look into it, but basically the solution you have (and the bit shorter one i gave you) is the official way.
it doesn't feel like a normal use case, but if you really want, just add the root folder as a member and than you won't need to do anything at all in your makefile (i hope).

[sagiegurari]

by the way, if you do not want to add it to the members in cargo.toml there is a way to define it in the makefile using the workspace emulation env vars. but.... its more for projects that want to be like a workspace without cargo knowing about it.

[augustocdias]

@sagiegurari
Something that I believe that could be improved is about task resolution in workspaces.

I'd like to have my CI and all commands running from the root directory. So when I run a task that exists in a sub project but not in another I'd be expect it to just ignore and not do anything where this task doesn't exist and run only where it exists. If it matches no project then it should fail.

One example. I have a workspace that contains several crates. Some of them uses sqlx, but not all. I have a task to lint the queries on those that have this dependency. I don't want to navigate to each project in my CI and run on each individually. I want from the root to just run cargo make lint-sql on the root, then it should execute in all children that has this task defined and ignore those that hasn't. Instead it fails because some children don't have the task defined.

[sagiegurari]

sorry for late reply, i missed yours.

the problem with your suggestion, as i see it and based on feedback from others, is that you don't get feedback.
for example, lets say you have multiple crates and for one you misspelled build with biuld. the flow will run and you won't see any error.

cargo-make does have a solution for it, you can create empty tasks for that.
you can share automatically the workspace level makefile that can define those so you don't have to do anything in the crate level.
but to hide a possible issue that you want to run task X and its not defined at all, can be an issue.

in fact recently i added toml validation because someone was debugging for a long time why his flow not working and it seems he misspelled some attribute (see #506)

[augustocdias]

I understand and I think your argument is fair.