Skip to content

Commit 2d3dc03

Browse files
author
David Galloway
committed
Revert "dpdk: drop dpdk submodule"
This reverts commit cb8087d. The seastar submodule's .gitmodules links to `../dpdk` which is no longer present after removing dpdk from ceph.git's .gitmodules. ``` <dwfreed> the ceph/seastar repo uses awful URLs for the submodules <dwfreed> and those awful URLs are the real reason it's failing <dwfreed> dgalloway: ^^^ <dwfreed> seastar's .gitmodules references repos in the parent directory, so that when it's checked out as a submodule of ceph, you don't download the repos twice (and git will probably also use references instead of duplicating the local .git); however, ceph doesn't have a submodule for dpdk anymore <dwfreed> so seastar's referencing a dpdk repo that doesn't exist <dgalloway> i think i follow. so you're suggesting revert ceph@cb8087d ? <dwfreed> yep <dwfreed> that'd be one way to fix it ... <joshd> dgalloway: I'd suggest revert for now, and let the crimson folks figure out the longer term fix when they're back ``` Signed-off-by: David Galloway <[email protected]>
1 parent 2954c60 commit 2d3dc03

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
url = https://github.com/ceph/lua.git
4141
branch = lua-5.3-ceph
4242
ignore = dirty
43+
[submodule "src/dpdk"]
44+
path = src/dpdk
45+
url = https://github.com/ceph/dpdk
4346
[submodule "src/zstd"]
4447
path = src/zstd
4548
url = https://github.com/facebook/zstd

0 commit comments

Comments
 (0)