From b64e359d5485dda4b4b5074494155d18e25c8d13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Onur=20=C3=87elebi?= Date: Tue, 5 May 2020 02:09:45 -0700 Subject: [PATCH] fix test-label bug Summary: `Meter` didn't count golds for individual numbers any more when `falseNegativeLabels_` is false. Reviewed By: EdouardGrave Differential Revision: D21379435 fbshipit-source-id: b898c5d156727a0f001db5efbf72fd0bf6640efb --- src/meter.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/meter.cc b/src/meter.cc index b9077dce1..5d3dd09ab 100644 --- a/src/meter.cc +++ b/src/meter.cc @@ -39,9 +39,9 @@ void Meter::log( labelMetrics_[prediction.second].scoreVsTrue.emplace_back(score, gold); } - if (falseNegativeLabels_) { - for (const auto& label : labels) { - labelMetrics_[label].gold++; + for (const auto& label : labels) { + labelMetrics_[label].gold++; + if (falseNegativeLabels_) { if (!utils::containsSecond(predictions, label)) { labelMetrics_[label].scoreVsTrue.emplace_back(falseNegativeScore, 1.0); }