Avoid infinite recursion in Numeric#==

samleb · Mar 25, 2009 · 518d262 · 518d262
1 parent d948e10
commit 518d262
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/kernel/common/numeric.rb b/kernel/common/numeric.rb
@@ -96,7 +96,12 @@ def >=(other)
 
   def ==(other)
     return true if other.equal?(self)
-    !!(other == self)
+    if other.kind_of? Numeric
+      b, a = other.coerce self
+      a == b
+    else
+      !!(other == self)
+    end
   end
 
   def <=>(other)

diff --git a/spec/tags/frozen/library/rational/divmod_tags.txt b/spec/tags/frozen/library/rational/divmod_tags.txt
@@ -1,2 +1 @@
 fails:Rational#divmod when passed [Integer] returns the quotient as Integer and the remainder as Rational
-fails:Rational#divmod when passed [Float] returns the quotient as Integer and the remainder as Float
diff --git a/spec/tags/frozen/library/rational/to_i_tags.txt b/spec/tags/frozen/library/rational/to_i_tags.txt
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		fails:Rational#divmod when passed [Integer] returns the quotient as Integer and the remainder as Rational
		fails:Rational#divmod when passed [Float] returns the quotient as Integer and the remainder as Float