You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The channel is reset to the original position. It looks like a solution to maintain the state of the channel even in the case of failure, as the FileChannel.read does. After #1014, the reset is also done in the compressed reference. This could have performance effects, and it does not look completely necessary.
The text was updated successfully, but these errors were encountered:
magicDGS
changed the title
Is it needed that IndexedFastaSequenceFile resets the channel in every read operation?
Does IndexedFastaSequenceFile need to reset its channel in every read operation?
May 28, 2018
Concretely in the following codepath:
htsjdk/src/main/java/htsjdk/samtools/reference/IndexedFastaSequenceFile.java
Lines 285 to 297 in 854d736
The channel is reset to the original position. It looks like a solution to maintain the state of the channel even in the case of failure, as the
FileChannel.read
does. After #1014, the reset is also done in the compressed reference. This could have performance effects, and it does not look completely necessary.The text was updated successfully, but these errors were encountered: