Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour when parsing lists in INFO field #261

Open
holtgrewe opened this issue Jun 1, 2015 · 3 comments
Open

Unexpected behaviour when parsing lists in INFO field #261

holtgrewe opened this issue Jun 1, 2015 · 3 comments
Labels

Comments

@holtgrewe
Copy link

I have a VCF file with an INFO field that has A many values, but these values can be empty, as demonstrated below. Reading this with HTSJDK leads to the FI and FS fields having one atomic value instead of a list of two values.

Is this intented behaviour?

1       69360   .       C       A,G     .       .       RV=C>*,C>W;GN=OR4F5;UG=OR4F5_HUMAN;VI=stop_gain,;UV=C90*,C90W;FI=,high;FS=,4.765
@yfarjoun
Copy link
Contributor

yfarjoun commented Apr 1, 2019

going over old issues...

The missing string should be the empty string, but it isn't clear the the double array is legal since the spec doesn't seem to allow for missing individual fields in an array. so that would have to be an error.

I think that if strict pasrsing is requested, this record should be deemed not conformant due to the float array, and the string array should have returned one empty string.

@yfarjoun yfarjoun added the bug label Apr 1, 2019
@holtgrewe
Copy link
Author

Thanks for considering this issue.

I don't see in the specs where empty strings are disallowed.

@yfarjoun
Copy link
Contributor

yfarjoun commented Apr 2, 2019

I agree.. an empty string should have been created, but not a missing float

yfarjoun pushed a commit to yfarjoun/htsjdk that referenced this issue Jun 5, 2019
Mention that these conventions apply to *some* tag names where L/P/Q
acts as a name suffix -- for others, like DP, the L/P/Q is just part
of the name. Replaces and closes samtools#261.

Fix quote marks and maths formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants