Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the entire Reference class private #158

Open
sappelhoff opened this issue Aug 31, 2024 · 1 comment
Open

Make the entire Reference class private #158

sappelhoff opened this issue Aug 31, 2024 · 1 comment
Labels
API changing the interace of pyprep maintenance basic code health tasks
Milestone
0.5.0

Comments

@sappelhoff
Copy link
Owner

https://pyprep.readthedocs.io/en/latest/generated/pyprep.Reference.html#

From my point of view, users should call pyprep.PrepPipeline(...).fit(), which then calls the Reference class and its methods in the correct order.

Please respond here if you think this class should remain public, and why.
@sappelhoff sappelhoff added this to the 0.5.0 milestone Aug 31, 2024
@sappelhoff sappelhoff added API changing the interace of pyprep maintenance basic code health tasks labels Aug 31, 2024
@sappelhoff
Copy link
Owner Author

This would clash with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API changing the interace of pyprep maintenance basic code health tasks
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@sappelhoff