From 042684d8e5bdaae136bb00e5cbb4220dd7c624ce Mon Sep 17 00:00:00 2001 From: Stephanie Federwisch Date: Fri, 9 Jan 2015 16:04:55 -0800 Subject: [PATCH] Cleaning up in response to code review --- core/templates/dev/head/editor/EditorServices.js | 4 ++-- core/templates/dev/head/editor/ExplorationStatistics.js | 2 +- core/templates/dev/head/editor/exploration_statistics.html | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/templates/dev/head/editor/EditorServices.js b/core/templates/dev/head/editor/EditorServices.js index f72797a39175..08f3672497d9 100644 --- a/core/templates/dev/head/editor/EditorServices.js +++ b/core/templates/dev/head/editor/EditorServices.js @@ -831,8 +831,8 @@ oppia.factory('computeGraphService', [function() { nodes[stateName] = stateName; var handlers = states[stateName].widget.handlers; - for (h = 0; h < handlers.length; h++) { - ruleSpecs = handlers[h].rule_specs; + for (var h = 0; h < handlers.length; h++) { + var ruleSpecs = handlers[h].rule_specs; for (i = 0; i < ruleSpecs.length; i++) { links.push({ source: stateName, diff --git a/core/templates/dev/head/editor/ExplorationStatistics.js b/core/templates/dev/head/editor/ExplorationStatistics.js index e3327748367d..210468cf4705 100644 --- a/core/templates/dev/head/editor/ExplorationStatistics.js +++ b/core/templates/dev/head/editor/ExplorationStatistics.js @@ -63,7 +63,7 @@ oppia.controller('ExplorationStatistics', [ $http.get(explorationDataUrl).then(function(response) { var states = response.data.states; var initStateName = response.data.init_state_name; - $scope.graphData = computeGraphService.compute(initStateName, states); + $scope.statsGraphData = computeGraphService.compute(initStateName, states); }); var data = response.data; diff --git a/core/templates/dev/head/editor/exploration_statistics.html b/core/templates/dev/head/editor/exploration_statistics.html index ff4262618da0..afe65407240f 100644 --- a/core/templates/dev/head/editor/exploration_statistics.html +++ b/core/templates/dev/head/editor/exploration_statistics.html @@ -27,8 +27,7 @@

Common learner paths

- -
+