Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] change --bg default to transparent #46

Closed
sassman opened this issue Jan 21, 2021 · 3 comments
Closed

[FEAT] change --bg default to transparent #46

sassman opened this issue Jan 21, 2021 · 3 comments
Labels
good first issue Good for newcomers Type: Enhancement New feature or request

Comments

@sassman
Copy link
Owner

sassman commented Jan 21, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Lot of sides where gif are embedded support meanwhile dark mode, so I would say it makes more sense to default the bg color to transparent. So that the white border is replaced by a transparent border.
@sassman sassman added good first issue Good for newcomers Type: Enhancement New feature or request labels Jan 21, 2021
@rijusougata13
Copy link
Contributor

can you explain a little more.Where i have to make changes?

@sassman
Copy link
Owner Author

sassman commented Jan 21, 2021 •
edited
Loading

Sure: cli.rs:38 it is

@sassman
Copy link
Owner Author

sassman commented Jan 21, 2021

has been closed with PR #47. Thanks again.

@sassman sassman closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sassman @rijusougata13