Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I get a false positive because I have luckypatcher installed #94

Open
maxpilotto opened this issue Apr 7, 2019 · 1 comment
Open

I get a false positive because I have luckypatcher installed #94

maxpilotto opened this issue Apr 7, 2019 · 1 comment
Labels
false positive

Comments

@maxpilotto
Copy link

Shouldn't the detectPotentiallyDangerousApps() method be removed from the isRooted() check since luckypatcher can be used even without root access?
@scottyab
Copy link
Owner

scottyab commented Jul 2, 2019

Fair point, it may be potentially dangerous but agree doesn't make sense for this to be in the primary isRooted() call. PR welcome.

@maxpilotto maxpilotto mentioned this issue Jul 2, 2019
Closed
@Zhuinden Zhuinden mentioned this issue Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false positive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottyab @stealthcopter @maxpilotto