Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Server and HTTP Client mode? #63

Open
ghost opened this issue Mar 21, 2018 · 1 comment
Open

Deprecate Server and HTTP Client mode? #63

ghost opened this issue Mar 21, 2018 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Mar 21, 2018

At present, extruct supports a HTTP API for "testing", but that carries a maintenance burden, and it invites feature-requests that may nudge it more and more into becoming a monolithic proxy service. That's not really where we want Extruct to be, I think.

Similarly with the HTTP-Client mode and the CLI tool that offers it - it's a mode of operation which probably shouldn't be our priority with extruct. I feel that if we provide a CLI client for extruct, it should probably just accept HTML through a Unix pipe or from a file, and operate on that. That way, people can use curl or wget or whatever else they like, and they won't worry about extruct's support for various HTTP client features.

Thoughts? :)

@ghost ghost added the question label Mar 21, 2018
@ghost ghost mentioned this issue Mar 21, 2018
@stummjr
Copy link
Contributor

stummjr commented Mar 29, 2018

@cathalgarvey I'm probably too biased to provide valuable feedback on this, as I've implemented the CLI in the past, but I think that it is an useful feature (at least I find myself using it frequently 😄).

But I totally agree with you on that extruct should just read stuff from a file/pipe, as it makes it easier to customize the requests as much as we need using a proper tool such as curl/wget.

IMHO, we should keep the CLI, but maybe change it so that extruct doesn't make the HTTP requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant