Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scvi-tools Jax support #1718

Open
1 of 4 tasks
martinkim0 opened this issue Oct 6, 2022 · 3 comments
Open
1 of 4 tasks

scvi-tools Jax support #1718

martinkim0 opened this issue Oct 6, 2022 · 3 comments
Assignees
Labels
enhancement jax meta Refers to many issues new model Proposals to implement new model P1

Comments

@martinkim0
Copy link
Contributor

martinkim0 commented Oct 6, 2022

This issue will serve as a parent thread for all issues related to supporting Jax-backend for scvi-tools models.

@martinkim0 martinkim0 added enhancement help wanted new model Proposals to implement new model dependencies Pull requests that update a dependency file meta Refers to many issues jax labels Oct 6, 2022
@martinkim0 martinkim0 self-assigned this Oct 6, 2022
@martinkim0
Copy link
Contributor Author

I think in the long term, it would be useful if our high-level API is framework-agnostic. Something like the following:

model = scvi.model.SCVI(adata, backend="jax")

or

model = scvi.model.SCVI(adata, backend="torch")

@adamgayoso
Copy link
Member

I think in the long term, it would be useful if our high-level API is framework-agnostic

We thought about this but it requires matching features exactly, which might be hard. But we should continue to evaluate this option.

@martinkim0
Copy link
Contributor Author

We thought about this but it requires matching features exactly, which might be hard. But we should continue to evaluate this option.

Oh I see, yeah in that case we can revisit this when more code is implemented.

@martinkim0 martinkim0 added P1 and removed help wanted dependencies Pull requests that update a dependency file labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement jax meta Refers to many issues new model Proposals to implement new model P1
Projects
None yet
Development

No branches or pull requests

2 participants