Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update GaussianCopula Unit Tests #428

Open
csala opened this issue May 12, 2021 · 0 comments
Open

Review and update GaussianCopula Unit Tests #428

csala opened this issue May 12, 2021 · 0 comments
Labels
data:single-table Related to tabular datasets internal The issue doesn't change the API or functionality

Comments

@csala
Copy link
Contributor

csala commented May 12, 2021

The GaussianCopula class underwent a few changes that were not fully taken into account on the unit tests side.

As a consequence, even though the tests do not fail, some tests set up a few unnecessary things and do not do all the necessary checks.

An example of this is the test__update_metadata, which mocks a self.get_model_kwargs return value that is later on not really used in the code being tested.

def test__update_metadata(self):

To fix this, the unit tests from the tests/unit/tabular/test_copulas.py module should be reviewed and updated appropriately.

@npatki npatki added the internal The issue doesn't change the API or functionality label May 21, 2021
@katxiao katxiao added the data:single-table Related to tabular datasets label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:single-table Related to tabular datasets internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

3 participants