Skip to content

Commit d1e943c

Browse files
committed
fix undefined
1 parent 08cd8e2 commit d1e943c

File tree

3 files changed

+28
-25
lines changed

3 files changed

+28
-25
lines changed

build/request.js

Lines changed: 15 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-tiny-http",
3-
"version": "1.2.5",
3+
"version": "1.2.7",
44
"description": "A tiny node.js http framework",
55
"main": "build/http.js",
66
"scripts": {

src/request.coffee

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
Form = require 'formidable'
22
Url = require 'url'
33
Cookie = require 'cookie'
4+
QueryString = require 'querystring'
45

56

67
class Request
@@ -20,10 +21,10 @@ class Request
2021
@uri = parts.href
2122
@path = if parts.pathname? then parts.pathname else '/'
2223
@port = @req.socket.remotePort
23-
@agent = @header 'user-agent'
24+
@agent = @header 'user-agent', ''
2425

2526
# detect host
26-
host = @header 'host'
27+
host = @header 'host', ''
2728
matched = host.match /^\s*([_0-9a-z-\.]+)/
2829
@host = if matched then matched[1] else null
2930

@@ -64,24 +65,24 @@ class Request
6465
@$ip
6566

6667

67-
header: (key, val = null) ->
68+
header: (key, val = undefined) ->
6869
key = key.toLowerCase()
6970
if @req.headers[key] then @req.headers[key] else val
7071

7172

72-
cookie: (key, val = null) ->
73+
cookie: (key, val = undefined) ->
7374
if @$cookies[key]? then @$cookies[key] else val
7475

7576

7677
is: (query) ->
77-
required = querystring.parse query
78+
required = QueryString.parse query
7879

7980
for k, v of required
80-
if v? && v.length > 0
81-
return yes if v != @get k
81+
if v.length > 0
82+
return no if v != @get k
8283
else
83-
return yes if (@get k) is null
84-
no
84+
return no if (@get k) is undefined
85+
yes
8586

8687

8788
set: (key, val = null) ->
@@ -91,12 +92,12 @@ class Request
9192
@$params[key] = val
9293

9394

94-
get: (key, defaults = null) ->
95+
get: (key, defaults = undefined) ->
9596
if @$params[key]? then @$params[key] else defaults
9697

9798

9899
file: (key) ->
99-
if @$files[key]? then @$files[key] else null
100+
if @$files[key]? then @$files[key] else undefined
100101

101102

102103
module.exports = Request

0 commit comments

Comments
 (0)