Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement transport compression #693

Open
Erk- opened this issue Aug 22, 2019 · 2 comments
Open

Implement transport compression #693

Erk- opened this issue Aug 22, 2019 · 2 comments
Labels
discord feature Related to Discord's functionality.

Comments

@Erk-
Copy link
Member

Erk- commented Aug 22, 2019

Implement zlib-stream transport compression which compresses everything and therefore is more effective.
@arqunis arqunis added the discord feature Related to Discord's functionality. label Aug 23, 2019
@ByteAlex
Copy link

I run into the same issue when writing my library, I have uploaded my fix as a small crate.
I hope this helps :)
https://crates.io/crates/zlib_stream

I recommend using a buffer-factor of 3-4 instead of the default buffer size.

Erk- added a commit to Erk-/serenity that referenced this issue Sep 18, 2021
@Erk-
Support for transport compression
c8d1d01 
This is a revive of serenity-rs#733

Closes serenity-rs#693
@Erk- Erk- mentioned this issue Sep 18, 2021
Merged
@arqunis arqunis closed this as completed Sep 21, 2021
@Erk-
Copy link
Member Author

Erk- commented Oct 17, 2024

This is still relevant as the implementation done in #1508 got reverted since it caused #1511.

@Erk- Erk- reopened this Oct 17, 2024
@fgardt fgardt mentioned this issue Nov 14, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discord feature Related to Discord's functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ByteAlex @Erk- @arqunis