Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloneNode on a ShadowRoot should always throw an error #34739

Closed
jdm opened this issue Dec 22, 2024 · 2 comments · Fixed by #34742
Closed

cloneNode on a ShadowRoot should always throw an error #34739

jdm opened this issue Dec 22, 2024 · 2 comments · Fixed by #34742
Assignees
@willypuzzle
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor.

Comments

@jdm
Copy link
Member

jdm commented Dec 22, 2024

Spec: https://dom.spec.whatwg.org/#dom-node-clonenode
Test: tests/wpt/tests/shadow-dom/Node-prototype-cloneNode.html
Code:

servo/components/script/dom/node.rs

Lines 2799 to 2801 in ffccc5c

if deep && self.is::<ShadowRoot>() {
return Err(Error::NotSupported);
}

@jdm jdm added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. labels Dec 22, 2024
@willypuzzle
Copy link
Contributor

can I grab this?

@jdm
Copy link
Member Author

jdm commented Dec 22, 2024

Yep!

@willypuzzle willypuzzle mentioned this issue Dec 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willypuzzle willypuzzle

Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clone node on a shadow root should always throw an error willypuzzle/servo
2 participants
@jdm @willypuzzle