Prevent invalid traceparent ("00-00000...") from being returned to the caller (dapr#7406)

* Prevent invalid traceparent ("00-00000...") from being returned to the caller

Signed-off-by: Karsten Wintermann <[email protected]>

* OpenTelemetry trace context not transmitted when using rawPayload with Kafka
Fixes dapr#7372

Signed-off-by: Karsten Wintermann <[email protected]>

---------

Signed-off-by: Karsten Wintermann <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Artur Souza <[email protected]>

Author: 3 people

pkg/channel/http/http_channel.go

@@ -350,9 +350,11 @@ func (h *Channel) constructRequest(ctx context.Context, req *invokev1.InvokeMeth
 
 	// HTTP client needs to inject traceparent header for proper tracing stack.
 	span := diagUtils.SpanFromContext(ctx)
-	tp := diag.SpanContextToW3CString(span.SpanContext())
+	if span.SpanContext().HasTraceID() {
+		tp := diag.SpanContextToW3CString(span.SpanContext())
+		channelReq.Header.Set("traceparent", tp)
+	}
 	ts := diag.TraceStateToW3CString(span.SpanContext())
-	channelReq.Header.Set("traceparent", tp)
 	if ts != "" {
 		channelReq.Header.Set("tracestate", ts)
 	}

pkg/channel/http/http_channel_test.go

@@ -811,3 +811,37 @@ func TestHealthProbe(t *testing.T) {
 	require.NoError(t, err)
 	assert.False(t, success)
 }
+
+func TestNoInvalidTraceContext(t *testing.T) {
+	ctx := context.Background()
+
+	handler := &testHandlerHeaders{}
+	testServer := httptest.NewServer(handler)
+	c := Channel{
+		baseAddress: testServer.URL,
+		client:      http.DefaultClient,
+		compStore:   compstore.New(),
+	}
+	req := invokev1.NewInvokeMethodRequest("method").
+		WithContentType("text/plain").
+		WithMetadata(map[string][]string{invokev1.ContentLengthHeader: {"1"}}).
+		WithHTTPExtension(http.MethodPost, "").
+		WithRawDataString("1")
+	defer req.Close()
+
+	// act
+	resp, err := c.InvokeMethod(ctx, req, "")
+
+	// assert
+	require.NoError(t, err)
+	defer resp.Close()
+	body, _ := resp.RawDataFull()
+	actual := map[string]string{}
+	json.Unmarshal(body, &actual)
+	traceparent, hasTraceparent := actual["Traceparent"]
+	require.NoError(t, err)
+	if hasTraceparent {
+		assert.NotEqual(t, "00-00000000000000000000000000000000-0000000000000000-00", traceparent)
+	}
+	testServer.Close()
+}