Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows.nvim conficts with size #227

Open
NormTurtle opened this issue May 4, 2023 · 7 comments
Open

windows.nvim conficts with size #227

NormTurtle opened this issue May 4, 2023 · 7 comments

Comments

@NormTurtle
Copy link

NormTurtle commented May 4, 2023

note : **PLEASE** be Chill while reading this

Describe the problem

Size is the Problem , window.nvim which i use everyday , is having confict with no-neck-pain
window.nvim is resizesing no-neck-pain unwantedly , which i do not want ,
here is the demonstration !

step to reproduce

  1. install WINDOW.nvim with animation enabled
  2. try to use no-neck-pain with it

WITH WINDOW.nvim OFF

2023-05-04_18-38-35.mp4

WITH WINDOW.nvim ON

2023-05-04_18-51-30.mp4

THE SOLUTION

  • IGNORE no-neck-pain from window.nvim

some WORKAROUND

i tried using window.nvim CONFIG
as

   ignore = {				
      buftype = { "quickfix" },
      filetype = { "NvimTree", "neo-tree", "undotree", "gundo","no-neck-pain" }
   },

PS : it din't worked

Final thought

i don't know if that's a issue or not , but Im having problem , with it

maybe its wrong with window.nvim 🤷 , idk man my knowledge to small 🤌

@NormTurtle
Copy link
Author

NormTurtle commented May 4, 2023

this is the whole config of no-neck-pain

require("no-neck-pain").setup({
    buffers = {
        right = { enabled = false, },
        scratchPad = {
            enabled = true,
            location = "~/Desktop/",
        },
        bo = {
            filetype = "md"
        },
    },
})

@shortcuts
Copy link
Owner

note : PLEASE be Chill while reading this

this made me laugh, I'm chill thanks for opening the issue and testing the plugin!


I guess this is indeed window.nvim trying to resize the padding buffers, I'll see if it's possible to make their ignore option work and let you know!

@NormTurtle
Copy link
Author

NormTurtle commented May 7, 2023

this made me laugh

im glad , i did that :) LOL


fun fact :

window.nvim has ignore filetype but i din't know the Filytype of no-neck-pain 🤷 , or i been lazy at that time :(

@shortcuts
Copy link
Owner

OK so I did some tests, I can confirm that it's windows.nvim that resizes the window.

window.nvim has ignore filetype but i din't know the Filytype of no-neck-pain 🤷 , or i been lazy at that time :(

The default filetype for NNP windows are no-neck-pain, but here you define bo.filetype = "md" (which make sense since you take notes in markdown) in your config, so the filetype is now md.

I guess the straight forward solution is to ignore md on the windows.nvim side, or to make a feature request on their side to allow ignore by filename, which would allow them to prevent resizing on files named like no-neck-pain.md

@NormTurtle
Copy link
Author

😬 i really don't know what to say now

@shortcuts
Copy link
Owner

You can open an issue on the windows.nvim side, with a reference to this one and see if they'd be keen to implement an ignore by filename option :D

@NormTurtle
Copy link
Author

i dont think they are goin to help us soon , there development is pretty much dead from months , :(
the last commit was pretty old
image

shortcuts added a commit that referenced this issue Mar 13, 2024
## 📃 Summary

saving state after important executions prevent inconsistencies when
accessing it, this will also allowing introducing debouncing at any time
of the plugin toggling, which might help for
#221 and
#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants