Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] support acquiring credentials from system keyring #18

Closed
simonmysun opened this issue Aug 2, 2024 · 1 comment
Closed

[feat] support acquiring credentials from system keyring #18

simonmysun opened this issue Aug 2, 2024 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@simonmysun
Copy link
Owner

This is more secured approach to store API keys. I still need to investigate how this works because I wasn't using it.

@simonmysun simonmysun added the enhancement New feature or request label Aug 2, 2024
@simonmysun
Copy link
Owner Author

After some research, I find this is currently better to achieved by a thirdparty tool, which loads an encrypted .env file. Using system secret such as OS X keychain or GNOME keyring is definitely the ideal case but so far I personally don't believe its effectiveness. Instead, I think it's user's responsibility to keep the secret from untrusted applications with approaches like sandboxes or namespaces. Therefore, for now I decide not to implement it. Please comment there is any suggestions.

@simonmysun simonmysun added the wontfix This will not be worked on label Aug 17, 2024
simonmysun added a commit that referenced this issue Aug 17, 2024
simonmysun added a commit that referenced this issue Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant