Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented API Endpoints #1367

Open
1 task done
csfore opened this issue Oct 24, 2022 · 1 comment
Open
1 task done

Undocumented API Endpoints #1367

csfore opened this issue Oct 24, 2022 · 1 comment

Comments

@csfore
Copy link

csfore commented Oct 24, 2022

Prerequisites

  • I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

Describe the bug

While looking through the API code, I discovered some undocumented endpoints.

Mailbox Endpoints

There are two undocumented API endpoints: /mailboxes and /v2/mailboxes, here, that use a GET method and are not mentioned in the mailbox documentation.

Settings Endpoints

In the Settings endpoint, /setting/unlink_proton_account using DELETE is undocumented. /setting/domains is also undocumented.

Notification Endpoint

There is a typo in the documentation that uses /notifications/<int:notification_id> when in the code it uses /notifications/<int:notification_id>/read.

Misc Endpoints

The endpoint /apple/update_notification (POST) is undocumented.

Expected behavior
Example JSON structures and appropriate headers for the endpoints in the documentation.

Screenshots
Undocumented Mailbox endpoint:
image
Undocumented Settings endpoint:
image
Notification Endpoint Typo:
image

@nguyenkims
Copy link
Contributor

@csfore some endpoints are indeed quite specific to the SaaS version and aren't useful for a self hosting instance and that's why they aren't documented. For example, the /apple/update_notification endpoint is only useful for the Apple in-app purchase integration or /setting/unlink_proton_account is only used in the SimpleLogin-Proton integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants