Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for 'trezor' and 'ledger' identities #161

Open
astroseger opened this issue Dec 26, 2018 · 1 comment
Open

add tests for 'trezor' and 'ledger' identities #161

astroseger opened this issue Dec 26, 2018 · 1 comment

Comments

@astroseger
Copy link
Collaborator

We should add tests for trezor and ledger identities, especially for sign_message_after_soliditySha3 function.

We should take software simulators for those hardware keys and test them in our functional tests (in snet-cli/test/functional_tests)
@astroseger
Copy link
Collaborator Author

@raamb I think we should add beta label here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astroseger