Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide correction]Image building issue for the first Singularity file #5

Closed
kangzhiq opened this issue May 12, 2020 · 4 comments
Closed

Comments

@kangzhiq
Copy link
Contributor

Links

N/A

Version of Singularity

N/A

Behavior when Building Locally

N/A

Error on Singularity Hub

The Singularity file created before Add a new repository is not built.

What do you think is going on?

I am new to Singularity so I followed the Use Guide step by step to create my first image: Build A Contrainer

In the User Guide, it is recommended to create a first Singularity file before adding the repository to Singularity Hub: Steps

However, I noticed that by doing so, the predefined Singularity will not trigger a build in the Automated Build mode.

After reading the documentation of Automated Build, I notice that Singularity Hub will only check the commits after the connection being established. Thus, if we follow the steps described in the user guide, the very first Singularity is excluded, unless we modified this file later and commit again.

I suggest that in Steps, the connection should be established before committing the first Singularity file. (Verified and approved to be OK)

It is not a fatal issue but it would cause some trouble to understand what happened, especially for a newbie.

@vsoch
Copy link
Member

vsoch commented May 12, 2020

Thanks for the feedback! If you'd like to open a PR to update the docs to something you think would be better, please feel free to do so - they are hosted at the repository https://github.com/singularityhub/singularityhub-docs.

@vsoch vsoch transferred this issue from singularityhub/singularityhub.github.io May 12, 2020
@vsoch
Copy link
Member

vsoch commented May 12, 2020

I've just transferred the issue to be under the docs repository. Looking forward to your contribution!

@kangzhiq
Copy link
Contributor Author

I've just transferred the issue to be under the docs repository. Looking forward to your contribution!

@vsoch
Ok! I will open a PR lately. Thank you a lot!

@vsoch
Copy link
Member

vsoch commented Jan 1, 2021

This was done! Thanks again @kangzhiq.

@vsoch vsoch closed this as completed Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants