Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading to different sub folder in S3 #2257

Open
kazazor opened this issue Jan 21, 2019 · 2 comments
Open

Allow uploading to different sub folder in S3 #2257

kazazor opened this issue Jan 21, 2019 · 2 comments

Comments

@kazazor
Copy link

kazazor commented Jan 21, 2019

I would like to suggest a feature request.
Currently, there is no option to specify the high-level subfolder within an S3 bucket to upload the files to.
Meaning, given bucket X, all files will be uploaded to S3 in the form:
x
|_url1
|_url2

I would like to be able to specify the high-level folder in which the URLs will be stored.

The need

I'm using the tool to test our URLs from different regions worldwide in order to mimic users from different places around the world.
The URL of the website is the same, but the user is coming from a different location. Just setting up a new EC2 instance on different AWS region.

I would like to separate the results from different locations without creating a bucket for each location, it's a bit messy.

If anyone has any idea on another approach to do that, I would love to hear it :)

Example

X
|_Ohio
| |___url1
|_Tokyo
|___url1

More info

Version: 8.0.0

@soulgalore
Copy link
Member

Hi @kazazor yes that sounds like a good idea. It would work right if we just add another cli param something like --s3.folder ? And then just add it here: https://github.com/sitespeedio/sitespeed.io/blob/master/lib/plugins/s3/index.js#L57

Do you have time to make a PR? I can help out testing it?

Best
Peter

@kazazor
Copy link
Author

kazazor commented Jan 21, 2019

Sure thing, I'll find the time for it :)

@soulgalore soulgalore added the s3 AWS S3 label Jun 25, 2020
@soulgalore soulgalore removed the prio:5 label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants